#47627 changelog iteration should ignore cleaned rids when getting the minCSN
Closed: wontfix None Opened 7 years ago by mreynolds.

If a change is not found in the change log the server will look for a min csn to start the replay. This minCSN should not come from a cleaned RUV element.


the fix is ok, but when do we ever want to consider a cleaned rid ?

Replying to [comment:4 lkrispen]:

the fix is ok, but when do we ever want to consider a cleaned rid ?

As mentioned in the meeting and to keep the ticket updated: Why not just always ignore cleaned rids? We must not ignore updates from cleaned rids when purging the changelog - so there are cases where we want to ignore cleaned rids, and cases where we do not want to ignore them.

git merge
Updating 0d4849d..9c6e9bb
Fast-forward
ldap/servers/plugins/replication/cl5_api.c | 2 +-
ldap/servers/plugins/replication/repl5_ruv.c | 42 ++++++++++++++++++++-----
ldap/servers/plugins/replication/repl5_ruv.h | 3 ++
3 files changed, 37 insertions(+), 10 deletions(-)

git push origin master
Counting objects: 17, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (9/9), done.
Writing objects: 100% (9/9), 1.29 KiB, done.
Total 9 (delta 7), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
0d4849d..9c6e9bb master -> master

commit 9c6e9bb
Author: Mark Reynolds mreynolds@redhat.com
Date: Wed Dec 11 11:25:44 2013 -0500

5d3ae5f..37d922f 389-ds-base-1.3.2 -> 389-ds-base-1.3.2

2a92a6c..8004449 389-ds-base-1.3.1 -> 389-ds-base-1.3.1

75ed4b3..5dfbef1 389-ds-base-1.3.0 -> 389-ds-base-1.3.0

1eb281a..e746f7e 389-ds-base-1.2.11 -> 389-ds-base-1.2.11

Logging fix:

git merge ticket47627
Updating 080cb44..20cccf5
Fast-forward
ldap/servers/plugins/replication/cl5_api.c | 13 +++++++++----
1 files changed, 9 insertions(+), 4 deletions(-)

git push origin master
080cb44..20cccf5 master -> master

commit 20cccf5
Author: Mark Reynolds mreynolds@redhat.com
Date: Sat Dec 14 07:38:12 2013 -0500

862f0d6..e43bb7d 389-ds-base-1.3.2 -> 389-ds-base-1.3.2

c094a9f..ae3daa1 389-ds-base-1.3.1 -> 389-ds-base-1.3.1

5dfbef1..78f20ee 389-ds-base-1.3.0 -> 389-ds-base-1.3.0

e746f7e..962de25 389-ds-base-1.2.11 -> 389-ds-base-1.2.11

Metadata Update from @mreynolds:
- Issue assigned to mreynolds
- Issue set to the milestone: 1.2.11.26

4 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/964

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)

6 months ago

Login to comment on this ticket.

Metadata