Right now the changelog trim interval is hard coded to 5 minutes (300 seconds). This interval should be configurable, if for no other reason than testing trimming.
Rich, I guess you missed my assigning this ticket to myself. I just wrote the patch, and was about to send it out for review
Replying to [comment:3 mreynolds]:
No, I saw you assign it to yourself, and thought I should attach the work I had already done last week, in case you wanted to use it.
Ahhh ok. Thanks! I didn't notice you attached a patch until I went to update the bug for my patch. Since there wasn't a separate comment I didn't get a email notification. (I wish trac would send out emails for new attachments).
work in progress 0001-Ticket-47617-allow-configuring-changelog-trim-interv.patch
git merge ticket47617 Updating d8e8a90..9f75027 Fast-forward ldap/servers/plugins/replication/cl5.h | 3 +- ldap/servers/plugins/replication/cl5_api.c | 17 ++++-- ldap/servers/plugins/replication/cl5_api.h | 63 ++++++++++++------------ ldap/servers/plugins/replication/cl5_config.c | 40 ++++++++++++--- ldap/servers/plugins/replication/cl5_init.c | 2 +- ldap/servers/plugins/replication/cl5_test.c | 2 +- ldap/servers/plugins/replication/repl_shared.h | 1 + 7 files changed, 80 insertions(+), 48 deletions(-)
git push origin master Counting objects: 25, done. Delta compression using up to 4 threads. Compressing objects: 100% (13/13), done. Writing objects: 100% (13/13), 2.03 KiB, done. Total 13 (delta 11), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git d8e8a90..9f75027 master -> master
commit 9f75027 Author: Mark Reynolds mreynolds@redhat.com Date: Wed Dec 11 16:57:24 2013 -0500
git push origin 389-ds-base-1.3.2
a2fa1cb..668e85c 389-ds-base-1.3.2 -> 389-ds-base-1.3.2
Ticket has been cloned to Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=1044177
Added attribute value validation 0001-Ticket-47617-replication-changelog-trimming-setting-.patch
The fix looks good. A question is the change for ldap/schema/01core389.ldif is needed? It looks to me the syntax checking using the schema and the checks on the strtol result in cl5_config.c are redundant... (but I could be wrong...)
Replying to [comment:11 nhosoi]:
The fix looks good. A question is the change for ldap/schema/01core389.ldif is needed?
This enforces the single value (verses multivalued).
It looks to me the syntax checking using the schema and the checks on the strtol result in cl5_config.c >are redundant... (but I could be wrong...)
Replying to [comment:12 mreynolds]:
Replying to [comment:11 nhosoi]: The fix looks good. A question is the change for ldap/schema/01core389.ldif is needed? This enforces the single value (verses multivalued).
I see. I guess you already tested it, so I trust your result. ;) The single value is guaranteed even if the attribute value is not defined as any attribute of objectclass, right?
Replying to [comment:13 nhosoi]:
Replying to [comment:12 mreynolds]: Replying to [comment:11 nhosoi]: The fix looks good. A question is the change for ldap/schema/01core389.ldif is needed? This enforces the single value (verses multivalued). I see. I guess you already tested it, so I trust your result. ;) The single value is guaranteed even if the attribute value is not defined as any attribute of objectclass, right?
Correct. It's in a entry that uses "objectclass: extensibleObject" and it is still enforced.
2c6e74a..f724b34 master -> master commit f724b34 Author: Mark Reynolds mreynolds@redhat.com Date: Mon Jan 12 14:58:56 2015 -0500
baa26c9..87c7b15 389-ds-base-1.3.3 -> 389-ds-base-1.3.3 commit 87c7b15
a9dee00..20cb0c0 389-ds-base-1.3.2 -> 389-ds-base-1.3.2 commit 20cb0c0
Metadata Update from @mreynolds: - Issue assigned to mreynolds - Issue set to the milestone: 1.3.2.9
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/954
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Log in to comment on this ticket.