This bug is to cleanup the various functions related to replication that are not in the right class and/or duplicate and/or does not use exception for error handling
functions to cleanup are at least lib389.enableReplication (likely duplicate of replica.add) lib389.createAgreement (likely duplicate of agreement.create) replica.check_init, replica.wait_init, replica.start_and_wait, keep_in_sync, agreements, agreement_changes that are likely to be moved in agreement.
attachment 0001-Ticket-47600-Replica-Agreement-Changelog-not-conform.patch
attachment 0001-Ticket-47600-follow-up-Replica-Agreement-Changelog-n.patch
ack
git merge workAgreement Updating 53cf060..3baf34d Fast-forward lib389/init.py | 81 +-------- lib389/_constants.py | 31 +++- lib389/_entry.py | 34 ++++ lib389/agreement.py | 645 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ lib389/brooker.py | 798 ---------------------------------------------------------------------------------------- lib389/changelog.py | 96 +++++++++++ lib389/properties.py | 156 +++++++++++++++--- lib389/replica.py | 553 +++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++ lib389/suffix.py | 8 + tests/agreement_test.py | 321 ++++++++++++++++++++++++++++++++++++ tests/replica_test.py | 935 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++----------------------------------- 11 files changed, 2441 insertions(+), 1217 deletions(-) create mode 100644 lib389/agreement.py create mode 100644 lib389/changelog.py create mode 100644 lib389/replica.py create mode 100644 tests/agreement_test.py
git push origin master Enter passphrase for key '/home/tbordaz/.ssh/id_rsa_fedora': Counting objects: 25, done. Delta compression using up to 4 threads. Compressing objects: 100% (15/15), done. Writing objects: 100% (15/15), 21.68 KiB, done. Total 15 (delta 9), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/lib389.git/ 53cf060..3baf34d master -> master
commit 3baf34db9be6cdc289c826a8e5d7722242a42110 Author: Thierry bordaz (tbordaz) tbordaz@redhat.com Date: Mon Jan 6 17:26:05 2014 +0100
Milestone lib389 1.0 deleted
Metadata Update from @tbordaz: - Issue assigned to tbordaz
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/937
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.