I just tried to run the static analysis checker over the source code of the 389-admin-1.1.31 project.
The checker said
[lib/libdsa/dsalib_updown.c:580]: (error) Resource leak: CmdFile
$ fgrep CmdFile ../BUILD/389-admin-1.1.31/lib/libdsa/dsalib_updown.c FILE *CmdFile; CmdFile = fopen(line, "r"); if (!CmdFile) if (!fread(cmd, 1, BIG_LINE, CmdFile)) $
It looks like a missing call to fclose to me.
The specific code is inside of "#if defined( XP_WIN32 ) ... #endif", which was written for Windows. The current version of Admin Server does not support Windows.
Metadata Update from @nhosoi: - Issue assigned to nhosoi - Issue set to the milestone: N/A
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/642
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Invalid)
Login to comment on this ticket.