#47303 start/stop/restart dirsrv scripts should report and error if no instances
Closed: wontfix None Opened 8 years ago by rmeggins.

If there are no instances, and you run e.g. start-dirsrv, you get a very strange output:

Starting instance "*"
Instance admin-serv not found.

or Instance bin or some other strangeness. It should just detect if no instances exist, report so, and exit with an error code.


0003-Ticket-47303-start-stop-restart-dirsrv-scripts-shoul.patch
0003-Ticket-47303-start-stop-restart-dirsrv-scripts-shoul.patch

When I run start-dirsrv(without your fix) from a random directory, it looks for all the files in the current directory. Its seems to be very broken.

[root@localhost BUILD]# start-dirsrv
Starting instance "*"
Instance config.h not found.

[root@localhost ds]# start-dirsrv
Starting instance "*"
Instance 0001-Ticket-332-Fix-usage-in-scripts.patch not found.

[root@localhost ds]# ls
0001-Ticket-332-Fix-usage-in-scripts.patch
...
...

With your fix:

[root@localhost BUILD]# start-dirsrv
No instances found in /root/.dirsrv

Yep, looks like this is broken, if you do a su to root (not su - root):
{{{

su
Password:

sh -x sbin/start-dirsrv

  • '[' rich = root ']'
  • initconfig_dir=/root/.dirsrv

echo $USER

rich

echo $HOME

/root

id

uid=0(root) gid=0(root) groups=0(root),1(bin),2(daemon),3(sys),4(adm),6(disk),10(wheel) context=unconfined_u:unconfined_r:unconfined_t:s0-s0:c0.c1023
}}}
So once again, foiled by depending on the value of $USER to be correct. Working on a patch to use id instead

Note that if you do su - root instead of just a plain "su" the $USER is set correct to root, but we cannot rely on that

The
{{{
No instances found in /root/.dirsrv
}}}
is fixed in https://fedorahosted.org/389/ticket/47299

commit a10e433
Author: Rich Megginson rmeggins@redhat.com
Date: Thu Mar 21 13:25:43 2013 -0600

Metadata Update from @rmeggins:
- Issue assigned to rmeggins
- Issue set to the milestone: 1.3.1

4 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/640

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)

9 months ago

Login to comment on this ticket.

Metadata