#468 if pam_passthru is enabled, need to AC_CHECK_HEADERS([security/pam_appl.h])
Closed: wontfix None Opened 9 years ago by rmeggins.

If doing configure and --enable-pam-passthru is set, we should check for the presence of the security/pam_appl.h header. Since --enable-pam-passthru is on by default, we should have this check.

Would placing AC_CHECK_HEADERS into the AC_ARG_ENABLE's 3rd arg not suffice?

AC_ARG_ENABLE([pam-passthru], [...],
    [AC_CHECK_HEADERS([security/pam_appl.h],
        [],
        [AC_MSG_ERROR([bla])])
    ])

Or one can probably also unconditionally check and only error out
when pam-passthru is chosen.

AC_CHECK_HEADERS([security/pam_appl.h])
AC_ARG_ENABLE([pam-passthru], [help text],
    [if test "$ac_cv_header_security_pam_appl_h" = no"; then
         AC_MSG_ERROR([bla])
        ])

git merge ticket468
Updating 70117a1..dbc0a95
Fast-forward
configure | 142 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
configure.ac | 2 +
2 files changed, 144 insertions(+), 0 deletions(-)

[mareynol@localhost plugins]$ git push origin master
Counting objects: 7, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (4/4), done.
Writing objects: 100% (4/4), 1.13 KiB, done.
Total 4 (delta 3), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
70117a1..dbc0a95 master -> master

[mareynol@localhost plugins]$ git checkout 389-ds-base-1.2.11
Switched to branch '389-ds-base-1.2.11'
[mareynol@localhost plugins]$ git cherry-pick -x master
Finished one cherry-pick.
[389-ds-base-1.2.11 96b9abe] Ticket 468 - if pam_passthru is enabled, need to AC_CHECK_HEADERS([security/pam_appl.h])
2 files changed, 144 insertions(+), 0 deletions(-)

[mareynol@localhost plugins]$ git push origin 389-ds-base-1.2.11
Counting objects: 7, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (4/4), done.
Writing objects: 100% (4/4), 1.18 KiB, done.
Total 4 (delta 3), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
283561b..96b9abe 389-ds-base-1.2.11 -> 389-ds-base-1.2.11

Metadata Update from @mreynolds:
- Issue assigned to mreynolds
- Issue set to the milestone: 1.3.0

4 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/468

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)

a year ago

Login to comment on this ticket.

Metadata