#466 entry_apply_mod - ADD: Failed to set unhashed#user#password to extension
Closed: Fixed None Opened 7 years ago by nhosoi.

When replication requests are held and restart the master, the requests are handled as soon as the replication start up function multimaster_start is called via plugin_startall, which is before pw_exp_init is called. Since the entry extension is not initialized yet, entry_apply_mod fails.

[...] entry_apply_mod - ADD: Failed to set unhashed#user#password to extension


Bug Description: If changes are stuck in the chagnelog and the
server is restarted, the changes are being replicated as soon
as plugin_startall is called.  At the point, the entry extension
has to be already initialized.

Fix Description: The entry extension initialization which used
to be called in pw_init.  Now it is moved to just before
plugin_startall in main.

Reviewed by Mark (Thank you!!)

Pushed to master.

$ git merge trac466
Updating 5beb93d..91d9836
Fast-forward
ldap/servers/slapd/main.c | 7 +++++++
ldap/servers/slapd/pw_mgmt.c | 3 ---
2 files changed, 7 insertions(+), 3 deletions(-)

$ git push
Enter passphrase for key '/home/nhosoi/.ssh/id_rsa':
Counting objects: 139, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (84/84), done.
Writing objects: 100% (84/84), 21.58 KiB, done.
Total 84 (delta 63), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
5beb93d..91d9836 master -> master

Cherry-picked and pushed to origin/389-ds-base-1.2.11.
$ git cherry-pick -x -e 91d9836
$ git push origin 389-ds-base-1.2.11-ext:389-ds-base-1.2.11
Counting objects: 13, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (7/7), done.
Writing objects: 100% (7/7), 1.10 KiB, done.
Total 7 (delta 5), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
2689bcb..db792db 389-ds-base-1.2.11-ext -> 389-ds-base-1.2.11

How to reproduce the problem:
Set up 2-way MMR.
Stress one master (master A).
While the updates are happening, kill the other master (master B).
Stop the updates, and shutdown the master A.
Start master B.
Then, start master A.
If the following strings are not logged in the master A's error log, the bug is verified.
"entry_apply_mod - ADD: Failed to set unhashed#user#password to extension"

Metadata Update from @nhosoi:
- Issue assigned to nhosoi
- Issue set to the milestone: 1.2.11.15

2 years ago

Login to comment on this ticket.

Metadata