Compiling the server with '--format-security' fails unless this patch is applied
attachment format-security.diff
I had to add "-Wformat-security -Werror=format-security"
FLAGS="-g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -Wformat-security -Werror=format-security -mtune=generic" CXXFLAGS="-g -pipe -Wall -Wp,-D_FORTIFY_SOURCE=2 -fexceptions -fstack-protector --param=ssp-buffer-size=4 -m64 -mtune=generic" ../ds/configure --enable-debug --with-openldap --with-fhs --with-selinux --libdir=/usr/lib64
Description of slapi_log_error: int slapi_log_error( int severity, char subsystem, char fmt, ... )
ruv_dump(const RUV ruv, char ruv_name, PRFileDesc *prFile) 1367 slapi_log_error(SLAPI_LOG_REPL, repl_plugin_name, buff); 1367 slapi_log_error(SLAPI_LOG_REPL, "%s", repl_plugin_name, buff); It should be 1367 slapi_log_error(SLAPI_LOG_REPL, repl_plugin_name, "%s", buff); ?
The rest looks good.
"ack"
oh whoops, you're right..
thanks
attachment 0001-TIcket-285-compilation-fixes-for-format-security.patch
Updating e2fd5bf..68c4ee3 Fast-forward ldap/servers/plugins/replication/repl5_ruv.c | 4 ++-- ldap/servers/slapd/passwd_extop.c | 8 ++++---- lib/base/pool.cpp | 10 +++++----- 3 files changed, 11 insertions(+), 11 deletions(-)
git push origin master Counting objects: 23, done. Delta compression using up to 4 threads. Compressing objects: 100% (12/12), done. Writing objects: 100% (12/12), 1.21 KiB, done. Total 12 (delta 10), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git e2fd5bf..68c4ee3 master -> master
originally targeted for 1.2.11.rc1, but actually in the 1.2.11.a1 release
Added initial screened field value.
Metadata Update from @tjaalton: - Issue assigned to mreynolds - Issue set to the milestone: 1.2.11.a1
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/285
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.