#17 Optimize validation of replicated data
Closed: wontfix None Opened 9 years ago by mkosek.

https://bugzilla.redhat.com/show_bug.cgi?id=750666

There are some optimizations we can make around validation of replicated data.
In particular, we could skip syntax checking for replicated operations since
the syntax checking of the new values should have been performed on the master
that initially received the operation from a client.  This optimization should
help improve performance of replicated operations.

We should add the ability to configure if syntax checking should be skipped for
replicated operations to allow flexibility for different deployments.  We also
may want to think if there are other things we could skip around replicated
operations, such as schema checking.

Still investigating but I think this functionality already exists:

Functions like:

slapi_entry_schema_check()
slapi_entry_syntax_check()
slapi_dn_syntax_check()
slapi_mods_syntax_check()

These all check if it is a replicated op, and exits if it is.

Still investigating...

[mareynol@localhost src]$ git merge ticket17
Updating 70f1c83..6f3f036
Fast-forward
ldap/servers/slapd/add.c | 33 +++++++++++++++++----------------
ldap/servers/slapd/modify.c | 4 ++--
2 files changed, 19 insertions(+), 18 deletions(-)

[mareynol@localhost src]$ git push origin master
Counting objects: 13, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (7/7), done.
Writing objects: 100% (7/7), 1.01 KiB, done.
Total 7 (delta 5), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
70f1c83..6f3f036 master -> master

Found a few more minor optimizations in the backend...

[mareynol@localhost back-ldbm]$ git merge ticket17
Updating 6f3f036..c08b916
Fast-forward
ldap/servers/slapd/back-ldbm/ldbm_add.c | 51 ++++++++++++---------
ldap/servers/slapd/back-ldbm/ldbm_modify.c | 69 ++++++++++++++++------------
2 files changed, 69 insertions(+), 51 deletions(-)

[mareynol@localhost back-ldbm]$ git push origin master
Counting objects: 15, done.
Delta compression using up to 4 threads.
Compressing objects: 100% (8/8), done.
Writing objects: 100% (8/8), 1.45 KiB, done.
Total 8 (delta 6), reused 0 (delta 0)
To ssh://git.fedorahosted.org/git/389/ds.git
6f3f036..c08b916 master -> master

Added initial screened field value.

Metadata Update from @mreynolds:
- Issue assigned to mreynolds
- Issue set to the milestone: 1.2.11.a1

4 years ago

389-ds-base is moving from Pagure to Github. This means that new issues and pull requests
will be accepted only in 389-ds-base's github repository.

This issue has been cloned to Github and is available here:
- https://github.com/389ds/389-ds-base/issues/17

If you want to receive further updates on the issue, please navigate to the github issue
and click on subscribe button.

Thank you for understanding. We apologize for all inconvenience.

Metadata Update from @spichugi:
- Issue close_status updated to: wontfix (was: Fixed)

9 months ago

Login to comment on this ticket.

Metadata