https://bugzilla.redhat.com/show_bug.cgi?id=184130
For a password modify operation (ldap modify or extop) we call new_passwdPolicy/delete_passwdPolicy 4 or more times (if all password checking is selected). I think it would be much more efficient to just call new_passwdPolicy once and stuff the policy object in the pblock, and have the different cases use the one in the pblock if present. This should work fine for all cases but the per user password policy case if that policy is being set at the same time as the password is being modified. In that case, we need to be very careful about the order of applying the change.
batch update moving tickets to future
set default ticket origin to Community
Added initial screened field value.
attachment 0001-Ticket-147-Internal-Password-Policy-usage-very-ineff.patch
git merge ticket147 Updating f33e73f..8639c03 Fast-forward ldap/servers/slapd/log.c | 2 +- ldap/servers/slapd/modify.c | 1 - ldap/servers/slapd/passwd_extop.c | 1 - ldap/servers/slapd/pblock.c | 7 ++-- ldap/servers/slapd/pw.c | 47 ++++++++------------------- ldap/servers/slapd/pw_mgmt.c | 6 --- ldap/servers/slapd/pw_retry.c | 3 -- ldap/servers/slapd/result.c | 1 - ldap/servers/slapd/slap.h | 63 +++++++++++++++++++------------------ 9 files changed, 51 insertions(+), 80 deletions(-)
[mareynol@localhost ds]$ git push origin master Counting objects: 27, done. Delta compression using up to 4 threads. Compressing objects: 100% (14/14), done. Writing objects: 100% (14/14), 1.79 KiB, done. Total 14 (delta 12), reused 0 (delta 0) To ssh://git.fedorahosted.org/git/389/ds.git f33e73f..8639c03 master -> master
Mark, I think this backport is because the fix fot 47900 did not apply to 1.2.11 - is this the only way to fix it ? I'm asking because I'm unsure which enhancements should be backported. Ludwig
Mark,
I think this backport is because the fix fot 47900 did not apply to 1.2.11 - is this the only way to fix it ? I'm asking because I'm unsure which enhancements should be backported.
Ludwig
Since ticket 458 was already backported to 1.2.11 (via customer request) we need 147 applied. Ticket 47900 was to complete the work that ticket 458 should of done -> ticket 458 did not take into account "add" operations.
German,
You are correct, my backport was wrong.
Working on a new patch...
This ticket does not need to be backported.
Metadata Update from @mreynolds: - Issue assigned to mreynolds - Issue set to the milestone: 1.3.0
389-ds-base is moving from Pagure to Github. This means that new issues and pull requests will be accepted only in 389-ds-base's github repository.
This issue has been cloned to Github and is available here: - https://github.com/389ds/389-ds-base/issues/147
If you want to receive further updates on the issue, please navigate to the github issue and click on subscribe button.
subscribe
Thank you for understanding. We apologize for all inconvenience.
Metadata Update from @spichugi: - Issue close_status updated to: wontfix (was: Fixed)
Login to comment on this ticket.