#132 Makefile.am must include header files and template scripts
Closed: Fixed None Opened 7 years ago by mkosek.


Description of problem:

The current Makefile.am in ldapserver doesn't include any
header files nor template script files (c.f. *.in), however,
these files must be included in Makefile.am, or 'make dist'
can't create proper distribution tarball correctly.

Version-Release number of selected component (if applicable):

How reproducible:

make dist

and check the generated tarball.

Steps to Reproduce:
1. ./configure
2. make dist
3. check the generated tarball such as fedora-ds-1.1.0a3.tar.gz

Actual results:

different between cvs tree and the contents of its tarball

Expected results:

tarball should consist of all the files required to

Additional info:

I attached the patch to add these files in Makefile.am
, but there're few things of which you have to take care.

I added header files in each <blah>_SOURCES by using
an ad-hoc script to add minimal required header
files to it. The script monitors errors for each
target and add necessary files to it and tries to rebuild
it. So if some file has been already included in tarball,
then the script can't detect nesessary files correctly.

Second problem is that the patch is not up-to-date
but for few days ago because the CVS HEAD is often
changed, but I send this patch to inform you about
this potential problem rather than creating appropriate
patch. This patch do as follows:

 * add header files for each <blah>_SOURCES
 * add original files for each <blah>_SCRIPTS
 * add other files in EXTRA_DIST

I hope this example helps this problem fix.

batch update to FUTURE milestone

set default ticket origin to Community

Added initial screened field value.

Fixed by Simo with this commit (and followings):
commit 5d98edd
Author: Simo Sorce simo@redhat.com
Date: Tue Sep 15 17:16:05 2015 -0400
Fix Makefile so that make dist works
Signed-off-by: Simo Sorce simo@redhat.com

Metadata Update from @nhosoi:
- Issue set to the milestone: 1.3.5 backlog

2 years ago

Login to comment on this ticket.