From fba9d48c4a6bf5ca2b148ed2e544e9b65f67dcbc Mon Sep 17 00:00:00 2001 From: Thierry Bordaz Date: Sep 26 2016 16:01:28 +0000 Subject: use a consumer maxcsn only as anchor if supplier is more advanced --- diff --git a/ldap/servers/plugins/replication/cl5_clcache.c b/ldap/servers/plugins/replication/cl5_clcache.c index 74f0fec..ca8b841 100644 --- a/ldap/servers/plugins/replication/cl5_clcache.c +++ b/ldap/servers/plugins/replication/cl5_clcache.c @@ -717,24 +717,22 @@ clcache_adjust_anchorcsn ( CLC_Buffer *buf, int *flag ) curr, conmaxcsn); } - if (csn_compare (cscb->local_maxcsn, cscb->prev_local_maxcsn) == 0 || - csn_compare (cscb->prev_local_maxcsn, buf->buf_current_csn) > 0 ) { - if (csn_compare (cscb->local_maxcsn, cscb->consumer_maxcsn) > 0 ) { + if (csn_compare(cscb->local_maxcsn, cscb->consumer_maxcsn) > 0) { + /* We have something to send for this RID */ + + if (csn_compare(cscb->local_maxcsn, cscb->prev_local_maxcsn) == 0 || + csn_compare(cscb->prev_local_maxcsn, buf->buf_current_csn) > 0) { + /* No new changes or it remains, in the buffer, updates to send */ rid_anchor = buf->buf_current_csn; - } - } else { - /* prev local max csn < csnBuffer AND different from local maxcsn */ - if (cscb->prev_local_maxcsn == NULL) { + } else { + /* prev local max csn < csnBuffer AND different from local maxcsn */ if (cscb->consumer_maxcsn == NULL) { /* the consumer hasn't seen changes for this RID */ rid_anchor = cscb->local_mincsn; rid_flag = DB_SET; - } else if ( csn_compare (cscb->local_maxcsn, cscb->consumer_maxcsn) > 0 ) { + } else { rid_anchor = cscb->consumer_maxcsn; } - } else { - /* csnPrevMaxSup > 0 */ - rid_anchor = cscb->consumer_maxcsn; } }