ef7473d Ticket #47820 - 1.2.11 branch: coverity errors

Authored and Committed by nhosoi 9 years ago
    Ticket #47820 - 1.2.11 branch: coverity errors
    
    Description:
    * Deadcode
    1. Defect type: UNUSED_VALUE
    1. 389-ds-base-1.2.11.15/ldap/servers/slapd/daemon.c:1894:returned_pointer – Pointer "slapdFrontendConfig" returned by "getFrontendConfig()" is never used.
       Solution: removed the line 1894.
    
    * Clang
    1. Defect type: CLANG_WARNING
    1. 389-ds-base-1.2.11.15/ldap/servers/slapd/valueset.c:1116:20:warning – Array access (via field 'va') results in a null pointer dereference
    2. Defect type: CLANG_WARNING
    1. 389-ds-base-1.2.11.15/ldap/servers/slapd/valueset.c:1090:26:warning – Array access (via field 'va') results in a null pointer dereference
       Solution: Added the code to check null dereference on vs->va on vs->va
    
    3. Defect type: CLANG_WARNING
    1. 389-ds-base-1.2.11.15/ldap/servers/slapd/daemon.c:1896:6:warning – Value stored to 'maxthreads' during its initialization is never read
       Solution: removed the line 1896.
    
    4. Defect type: CLANG_WARNING
    1. 389-ds-base-1.2.11.15/ldap/servers/slapd/daemon.c:1894:25:warning – Value stored to 'slapdFrontendConfig' during its initialization is never read
       Solution: Already addressed in Deadcode : 1. Defect type: UNUSED_VALUE
    
    5. Defect type: CLANG_WARNING
    1. 389-ds-base-1.2.11.15/ldap/servers/slapd/daemon.c:1091:21:warning – Dereference of null pointer (loaded from variable 'nap')
       Solution: Added the code to check null dereference on nap and *nap.
    
    6. Defect type: CLANG_WARNING
    1. 389-ds-base-1.2.11.15/ldap/servers/slapd/back-ldbm/ldbm_search.c:455:25:warning – Value stored to 'virtual_list_view' is never read
       Solution: Porting bug (bz1109952; DS 47780).  Moved the line to the right position.
    
    7. Defect type: CLANG_WARNING
    1. 389-ds-base-1.2.11.15/ldap/servers/slapd/back-ldbm/ldbm_add.c:1110:2:warning – Value stored to 'noabort' is never read
       Solution: Removed unnecessary assignment.
    
    Compiler Warnings
    12. Defect type: COMPILER_WARNING
    2. 389-ds-base-1.2.11.15/ldap/servers/slapd/daemon.c:1896:warning – unused variable 'maxthreads'
       Solution: already addressed 3. Defect type: CLANG_WARNING
    
    13. Defect type: COMPILER_WARNING
    1. 389-ds-base-1.2.11.15/ldap/servers/slapd/daemon.c:1895:warning – unused variable 'idletimeout'
       Solution: Removed the unused variable.
    
    14. Defect type: COMPILER_WARNING ¶
    1. 389-ds-base-1.2.11.15/ldap/servers/slapd/daemon.c:1894:warning – unused variable 'slapdFrontendConfig'
       Solution: already addressed 1. Defect type: UNUSED_VALUE
    
    15. Defect type: COMPILER_WARNING
    2. 389-ds-base-1.2.11.15/ldap/servers/slapd/daemon.c:1788:warning – 'compute_idletimeout' defined but not used
       Solution: removed the unused function.
    
    https://fedorahosted.org/389/ticket/47820
    
    Reviewed by rmeggins@redhat.com (Thanks, Rich!!)
    
        
file modified
+3 -5