ea9d4bb Ticket 48805 - Misleading indent and Uninitialised struct member

Authored and Committed by William Brown 7 years ago
35 files changed. 1474 lines added. 764 lines removed.
configure
file modified
+1 -0
ldap/servers/plugins/chainingdb/cb_bind.c
file modified
+5 -4
ldap/servers/plugins/collation/orfilter.c
file modified
+1 -1
ldap/servers/plugins/cos/cos_cache.c
file modified
+1 -1
ldap/servers/plugins/http/http_impl.c
file modified
+16 -15
ldap/servers/plugins/memberof/memberof.c
file modified
+1 -1
ldap/servers/plugins/memberof/memberof_config.c
file modified
+1 -1
ldap/servers/plugins/posix-winsync/posix-winsync.c
file modified
+12 -12
ldap/servers/plugins/replication/repl5_protocol_util.c
file modified
+4 -3
ldap/servers/plugins/replication/repl5_replica_config.c
file modified
+18 -17
ldap/servers/plugins/replication/repl5_total.c
file modified
+4 -4
ldap/servers/plugins/replication/windows_private.c
file modified
+1 -1
ldap/servers/plugins/replication/windows_protocol_util.c
file modified
+2 -2
ldap/servers/plugins/syntaxes/bin.c
file modified
+72 -29
ldap/servers/plugins/syntaxes/bitstring.c
file modified
+37 -16
ldap/servers/plugins/syntaxes/ces.c
file modified
+204 -99
ldap/servers/plugins/syntaxes/cis.c
file modified
+482 -203
ldap/servers/plugins/syntaxes/dn.c
file modified
+44 -22
ldap/servers/plugins/syntaxes/int.c
file modified
+91 -30
ldap/servers/plugins/syntaxes/nameoptuid.c
file modified
+43 -22
ldap/servers/plugins/syntaxes/numericstring.c
file modified
+92 -32
ldap/servers/plugins/syntaxes/syntax.h
file modified
+64 -22
ldap/servers/plugins/syntaxes/tel.c
file modified
+81 -39
ldap/servers/slapd/ldaputil.c
file modified
+2 -2
ldap/servers/slapd/log.c
file modified
+112 -110
ldap/servers/slapd/sasl_io.c
file modified
+1 -1
ldap/servers/slapd/tools/ldclt/ldapfct.c
file modified
+1 -1
ldap/servers/slapd/tools/rsearch/addthread.c
file modified
+1 -1
ldap/servers/slapd/tools/rsearch/searchthread.c
file modified
+1 -1
ldap/servers/slapd/uniqueid.c
file modified
+5 -4
ldap/servers/slapd/utf8compare.c
file modified
+1 -1
ldap/servers/slapd/uuid.c
file modified
+16 -13
ldap/servers/slapd/valueset.c
file modified
+15 -14
lib/libaccess/lasip.cpp
file modified
+6 -5
lib/libsi18n/txtfile.c
file modified
+36 -35
    Ticket 48805 - Misleading indent and Uninitialised struct member
    
    Bug Description:  Gcc 6.0 adds a number of new warning types that will help
    us proactively find errors. We should apply these fixes.
    
    Fix Description:
    * Fix misleading indent. This led to the infamous goto fail; goto fail;. This
    involves wrapping if branches in {}, and retabbing in some places. This means
    that as the developer reading the code, we can correct see what statements are
    guarded, and what is not.
    * Missing struct members: We were not completely intialising structs
    completely in many cases. Gcc was helping by padding the rest as '0', but we
    should be explicit in our code and actions.
    
    https://fedorahosted.org/389/ticket/48805
    
    Author: wibrown
    
    Review by: mreynolds (Thanks!)
    
        
file modified
+1 -0
file modified
+112 -110
file modified
+1 -1
file modified
+16 -13
file modified
+15 -14
file modified
+6 -5
file modified
+36 -35