ea033b6 Issue 49109 - nsDS5ReplicaTransportInfo should accept StartTLS as an option

Authored and Committed by spichugi 6 years ago
    Issue 49109 - nsDS5ReplicaTransportInfo should accept StartTLS as an option
    
    Bug Description: nsDS5ReplicaTransportInfo SSL vs TLS is not really clear,
    given that most libraries now support TLS as the default "SSL".
    We should make this clear in nsDS5ReplicaTransportInfo by allowing:
    ldaps -> SSL
    StartTLS -> TLS
    options. So that it's really clear what you are asking for when you configure it.
    
    Fix Description: Add additional options for nsDS5ReplicaTransportInfo - LDAPS and StartTLS.
    Legacy options will stay for some time and will deprecated in later version.
    Also, change the DNA plugin values in the same way.
    And rename replica flags through the code base as followed:
    TRANSPORT_FLAG_SSL -> TRANSPORT_FLAG_LDAPS
    TRANSPORT_FLAG_TLS -> TRANSPORT_FLAG_STARTTLS
    Also, check the change in the existing TLS replication test suite.
    
    https://pagure.io/389-ds-base/issue/49109
    
    Reviewed by: wibrown, mreynolds (Thanks!)