From cf849cc36fd94358c5b024ddfc421d8b42e59dfc Mon Sep 17 00:00:00 2001 From: Mark Reynolds Date: Jan 17 2020 15:46:41 +0000 Subject: Issue 50599 - Fix memory leak when removing db region files Description: An unnecessary flag was set in glob() that was resulting in a memory leak in the DS code. Removing this flag eliminated the leak. relates: https://pagure.io/389-ds-base/issue/50599 Reviewed by: --- diff --git a/ldap/servers/slapd/back-ldbm/db-bdb/bdb_layer.c b/ldap/servers/slapd/back-ldbm/db-bdb/bdb_layer.c index a929c88..1678529 100644 --- a/ldap/servers/slapd/back-ldbm/db-bdb/bdb_layer.c +++ b/ldap/servers/slapd/back-ldbm/db-bdb/bdb_layer.c @@ -1072,7 +1072,7 @@ bdb_start(struct ldbminfo *li, int dbmode) /* Better wipe out the region files to help ensure a clean start */ PR_snprintf(file_pattern, MAXPATHLEN, "%s/%s", region_dir, "__db.*"); - if (glob(file_pattern, GLOB_DOOFFS, NULL, &globbuf) == 0) { + if (glob(file_pattern, 0, NULL, &globbuf) == 0) { for (size_t i = 0; i < globbuf.gl_pathc; i++) { remove(globbuf.gl_pathv[i]); }