ca06547 Ticket #487 - Possible to add invalid attribute values to PAM PTA plugin configuration

Authored and Committed by tbordaz 11 years ago
    Ticket #487 - Possible to add invalid attribute values to PAM PTA plugin configuration
    
    Bug Description:
    	Original issue was discovered in 1.2.10 and was fixed in 1.2.11(and after) as a
    	side effect of ticket 181.
    	A minor issue was introduced by ticket181. When changing pamIDMapMethod with an
    	invalid value, the returned text is:
    		additional info: Error: valid values for pamMissingSuffix are
    		PAMPT_MISSING_SUFFIX_ERROR, PAMPT_MISSING_SUFFIX_ALLOW,
    		PAMPT_MISSING_SUFFIX_IGNORE
    	where it should be
    		additional info: Error: valid values for pamMissingSuffix are
    		ERROR, ALLOW, IGNORE
    
    	Ticket 487 is used to fix this minor issue
    
    Fix Description:
    	The fix is to let the macro to be preprocessed
    	The fix could be verified with the following test case:
    	Create an instance, enable pam-plugin, restart the instance,
    		ldapmodify ... <
    		dn: cn=PAM Pass Through Auth,cn=plugins,cn=config
    		changetype: modify
    		replace: pamMissingSuffix
    		pamMissingSuffix: invalid
    		EOF
    
    https://fedorahosted.org/389/ticket/487
    
    Reviewed by: Mark Reynolds (mareynol@redhat.com)