From a3c14c25726f4e156d0d8557129a054e7f8ed1c3 Mon Sep 17 00:00:00 2001
From: Noriko Hosoi <nhosoi@redhat.com>
Date: Mar 28 2013 22:40:47 +0000
Subject: Ticket 458 - Need to properly check if the password admin dn is set


Bug description: coverity reported "13160 - Resource leak"

Fix description: generate pblock after checking NULl check for binddn.

https://fedorahosted.org/389/ticket/458

Reviewed by Nathan (Thank you!!)

---

diff --git a/ldap/servers/slapd/pw.c b/ldap/servers/slapd/pw.c
index 3bb87d7..ae94903 100644
--- a/ldap/servers/slapd/pw.c
+++ b/ldap/servers/slapd/pw.c
@@ -1531,7 +1531,7 @@ pw_is_pwp_admin(Slapi_PBlock *pb, passwdPolicy *pwp){
 static void
 pw_get_admin_users(passwdPolicy *pwp)
 {
-	Slapi_PBlock *pb = slapi_pblock_new();
+	Slapi_PBlock *pb = NULL;
 	const Slapi_DN *sdn = pwp->pw_admin;
 	char **uniquemember_vals = NULL;
 	char **member_vals = NULL;
@@ -1546,9 +1546,11 @@ pw_get_admin_users(passwdPolicy *pwp)
 	if(binddn == NULL){
 		return;
 	}
+
 	/*
 	 *  Check if the DN exists and has "group" objectclasses
 	 */
+	pb = slapi_pblock_new();
 	slapi_search_internal_set_pb(pb, binddn, LDAP_SCOPE_BASE,"(|(objectclass=groupofuniquenames)(objectclass=groupofnames))",
 		NULL, 0, NULL, NULL, (void *) plugin_get_default_component_id(), 0);
 	slapi_search_internal_pb(pb);