From 975f86cf41083b91709445c2d5af889cf5aa2e3b Mon Sep 17 00:00:00 2001 From: Endi S. Dewata Date: Dec 09 2010 18:00:03 +0000 Subject: Bug 614511 - fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 https://bugzilla.redhat.com/show_bug.cgi?id=614511 Resolves: bug 614511 Bug description: Fix coverify Defect Type: Null pointer dereferences issues 11846 - 11891 description: Catch possible NULL pointer in slapi_dn_normalize_ext() and slapi_sdn_done(). --- diff --git a/ldap/servers/slapd/dn.c b/ldap/servers/slapd/dn.c index 0b74c4f..227a41e 100644 --- a/ldap/servers/slapd/dn.c +++ b/ldap/servers/slapd/dn.c @@ -1061,10 +1061,12 @@ slapi_dn_normalize_ext(char *src, size_t src_len, char **dest, size_t *dest_len) *dest_len = d - *dest; bail: if (rc < 0) { - if (*dest != src) { - slapi_ch_free_string(dest); - } else { - *dest = NULL; + if (dest != NULL) { + if (*dest != src) { + slapi_ch_free_string(dest); + } else { + *dest = NULL; + } } *dest_len = 0; } else if (rc > 0) { @@ -1981,6 +1983,10 @@ void slapi_sdn_done(Slapi_DN *sdn) { /* sdn_dump( sdn, "slapi_sdn_done"); */ + if(sdn==NULL) + { + return; + } if(sdn->dn!=NULL) { if(slapi_isbitset_uchar(sdn->flag,FLAG_DN))