From 92d7458355c775ddd62bb82c58cffe2472ee5ff9 Mon Sep 17 00:00:00 2001 From: Noriko Hosoi Date: Jul 23 2010 20:09:13 +0000 Subject: 610281 - fix coverity Defect Type: Control flow issues https://bugzilla.redhat.com/show_bug.cgi?id=610281 11794 DEADCODE Triaged Unassigned Bug Minor Ignore slapi_dn_syntax_check() ds/ldap/servers/slapd/plugin_syntax.c Comment: Checking for the possibility of dn == NULL is not needed since it is already checked at the line 303. --- diff --git a/ldap/servers/slapd/plugin_syntax.c b/ldap/servers/slapd/plugin_syntax.c index 5018326..174b136 100644 --- a/ldap/servers/slapd/plugin_syntax.c +++ b/ldap/servers/slapd/plugin_syntax.c @@ -319,7 +319,7 @@ slapi_dn_syntax_check( if (dn_plugin->plg_syntax_validate(&dn_bval) != 0) { if (syntaxlogging) { slapi_log_error( SLAPI_LOG_FATAL, "Syntax Check", - "DN value (%s) invalid per syntax\n", dn ? dn : ""); + "DN value (%s) invalid per syntax\n", dn); } if (syntaxcheck || override) {