7cc0f1d Issue 51132 - Winsync setting winSyncWindowsFilter not working as expected

Authored and Committed by mreynolds 3 years ago
    Issue 51132 - Winsync setting winSyncWindowsFilter not working as expected
    
    Bug Description:  When processing updates from AD we search AD using a filter,
                      and this filter can be customized via the attribute setting:
                      winSyncWindowsFilter.  However, after setting a custom filter
                      replication appears to stop working as expected.  New entries
                      that match the filter are replicated to DS, but not updates
                      to these entries.  The problem is that when dirsync sends
                      updates, it is just a partial entry - only containing the
                      attributes that changed.  Then the server checks the filter
                      again on the returned entry, but if it's just a mod update then
                      the entry is missing most of its attributes, and the filter
                      check fails and the entry is not updated on DS.
    
    Fix Description:  Do not check the filter on the returned entries when processing
                      incremental updates as the fitler test was already done when
                      gathering the candidates.
    
    relates: https://pagure.io/389-ds-base/issue/51132
    
    Reviewed by: tbordaz & firstyear (Thanks!)