From 7a334ca4966fd63fc5bbcd3ace3502cf8d283ae7 Mon Sep 17 00:00:00 2001
From: Mark Reynolds <mreynolds@redhat.com>
Date: May 28 2018 14:12:07 +0000
Subject: Ticket 49722 - Errors log full of " WARN - keys2idl - recieved NULL idl from index_read_ext_allids, treating as empty set" messages


Description:  If searching on entrydn, and the value is not found return an empty
              list instead of NULL.  This prevent these harmless error messages in
              log

https://pagure.io/389-ds-base/issue/49722

Reviewed by: ?

(cherry picked from commit e350a268d6f7cbaaad35187f3774093b140bc42c)

---

diff --git a/ldap/servers/slapd/back-ldbm/filterindex.c b/ldap/servers/slapd/back-ldbm/filterindex.c
index e8c3c20..aaa1d6e 100644
--- a/ldap/servers/slapd/back-ldbm/filterindex.c
+++ b/ldap/servers/slapd/back-ldbm/filterindex.c
@@ -990,7 +990,7 @@ keys2idl(
         }
 #endif
         if (idl2 == NULL) {
-            slapi_log_err(SLAPI_LOG_WARNING, "keys2idl", "recieved NULL idl from index_read_ext_allids, treating as empty set\n");
+            slapi_log_err(SLAPI_LOG_WARNING, "keys2idl", "received NULL idl from index_read_ext_allids, treating as empty set\n");
             slapi_log_err(SLAPI_LOG_WARNING, "keys2idl", "this is probably a bug that should be reported\n");
             idl2 = idl_alloc(0);
         }
diff --git a/ldap/servers/slapd/back-ldbm/index.c b/ldap/servers/slapd/back-ldbm/index.c
index 7e1cdd0..222f64d 100644
--- a/ldap/servers/slapd/back-ldbm/index.c
+++ b/ldap/servers/slapd/back-ldbm/index.c
@@ -966,7 +966,10 @@ index_read_ext_allids(
         slapi_sdn_init_dn_byval(&sdn, val->bv_val);
         rc = entryrdn_index_read(be, &sdn, &id, txn);
         slapi_sdn_done(&sdn);
-        if (rc) { /* failure */
+        if (rc == DB_NOTFOUND) {
+            /* return an empty list */
+            return idl_alloc(0);
+        } else if (rc) { /* failure */
             return NULL;
         } else { /* success */
             rc = idl_append_extend(&idl, id);