5b0c9c0 Ticket 48979 - Allow to compile 389ds with warning Wstrict-prototypes

145 files Authored by lslebodn 7 years ago, Committed by William Brown 7 years ago,
145 files changed. 976 lines added. 928 lines removed.
include/ldaputil/certmap.h
file modified
+1 -1
include/ldaputil/ldaputil.h
file modified
+1 -1
include/libaccess/aclproto.h
file modified
+1 -1
include/libadmin/libadmin.h
file modified
+1 -1
include/netsite.h
file modified
+1 -1
include/public/nsacl/plistdef.h
file modified
+1 -1
ldap/include/avl.h
file modified
+22 -13
ldap/libraries/libavl/avl.c
file modified
+13 -13
ldap/servers/plugins/acct_usability/acct_usability.c
file modified
+2 -2
ldap/servers/plugins/acctpolicy/acct_init.c
file modified
+1 -1
ldap/servers/plugins/acl/acl.h
file modified
+20 -20
ldap/servers/plugins/acl/acl_ext.c
file modified
+6 -6
ldap/servers/plugins/acl/acllist.c
file modified
+10 -9
ldap/servers/plugins/acl/aclplugin.c
file modified
+1 -1
ldap/servers/plugins/automember/automember.c
file modified
+7 -7
ldap/servers/plugins/automember/automember.h
file modified
+6 -6
ldap/servers/plugins/chainingdb/cb.h
file modified
+5 -5
ldap/servers/plugins/chainingdb/cb_conn_stateless.c
file modified
+2 -2
ldap/servers/plugins/cos/cos.c
file modified
+2 -2
ldap/servers/plugins/cos/cos_cache.c
file modified
+7 -7
ldap/servers/plugins/cos/cos_cache.h
file modified
+2 -2
ldap/servers/plugins/deref/deref.c
file modified
+2 -2
ldap/servers/plugins/dna/dna.c
file modified
+19 -19
ldap/servers/plugins/http/http_client.c
file modified
+1 -1
ldap/servers/plugins/http/http_client.h
file modified
+1 -1
ldap/servers/plugins/http/http_impl.c
file modified
+2 -4
ldap/servers/plugins/http/http_impl.h
file modified
+1 -1
ldap/servers/plugins/linkedattrs/linked_attrs.c
file modified
+4 -4
ldap/servers/plugins/linkedattrs/linked_attrs.h
file modified
+8 -8
ldap/servers/plugins/memberof/memberof.h
file modified
+12 -12
ldap/servers/plugins/mep/mep.c
file modified
+7 -7
ldap/servers/plugins/mep/mep.h
file modified
+6 -6
ldap/servers/plugins/pam_passthru/pam_passthru.h
file modified
+9 -9
ldap/servers/plugins/pam_passthru/pam_ptconfig.c
file modified
+3 -3
ldap/servers/plugins/passthru/passthru.h
file modified
+1 -1
ldap/servers/plugins/posix-winsync/posix-group-func.h
file modified
+4 -4
ldap/servers/plugins/posix-winsync/posix-winsync.c
file modified
+2 -2
ldap/servers/plugins/posix-winsync/posix-wsp-ident.h
file modified
+16 -16
ldap/servers/plugins/presence/presence.c
file modified
+9 -9
ldap/servers/plugins/pwdstorage/pwdstorage.h
file modified
+1 -1
ldap/servers/plugins/referint/referint.c
file modified
+14 -14
ldap/servers/plugins/replication/cl4.h
file modified
+2 -2
ldap/servers/plugins/replication/cl5.h
file modified
+4 -4
ldap/servers/plugins/replication/cl5_api.c
file modified
+30 -30
ldap/servers/plugins/replication/cl5_api.h
file modified
+9 -9
ldap/servers/plugins/replication/cl5_clcache.c
file modified
+4 -4
ldap/servers/plugins/replication/cl5_clcache.h
file modified
+2 -2
ldap/servers/plugins/replication/csnpl.h
file modified
+1 -1
ldap/servers/plugins/replication/legacy_consumer.c
file modified
+2 -2
ldap/servers/plugins/replication/llist.h
file modified
+1 -1
ldap/servers/plugins/replication/repl.h
file modified
+20 -12
ldap/servers/plugins/replication/repl5.h
file modified
+21 -21
ldap/servers/plugins/replication/repl5_inc_protocol.c
file modified
+1 -1
ldap/servers/plugins/replication/repl5_init.c
file modified
+1 -1
ldap/servers/plugins/replication/repl5_prot_private.h
file modified
+4 -4
ldap/servers/plugins/replication/repl5_replica_config.c
file modified
+4 -4
ldap/servers/plugins/replication/repl_init.c
file modified
+1 -1
ldap/servers/plugins/replication/repl_shared.h
file modified
+2 -2
ldap/servers/plugins/replication/replutil.c
file modified
+1 -1
ldap/servers/plugins/replication/windowsrepl.h
file modified
+1 -1
ldap/servers/plugins/rever/rever.h
file modified
+1 -1
ldap/servers/plugins/roles/roles_cache.c
file modified
+6 -6
ldap/servers/plugins/roles/roles_cache.h
file modified
+3 -3
ldap/servers/plugins/roles/roles_plugin.c
file modified
+1 -1
ldap/servers/plugins/rootdn_access/rootdn_access.c
file modified
+3 -3
ldap/servers/plugins/sync/sync.h
file modified
+2 -2
ldap/servers/plugins/sync/sync_persist.c
file modified
+4 -4
ldap/servers/plugins/syntaxes/bin.c
file modified
+1 -1
ldap/servers/plugins/syntaxes/bitstring.c
file modified
+1 -1
ldap/servers/plugins/syntaxes/ces.c
file modified
+1 -1
ldap/servers/plugins/syntaxes/cis.c
file modified
+1 -1
ldap/servers/plugins/syntaxes/dn.c
file modified
+1 -1
ldap/servers/plugins/syntaxes/int.c
file modified
+1 -1
ldap/servers/plugins/syntaxes/nameoptuid.c
file modified
+1 -1
ldap/servers/plugins/syntaxes/numericstring.c
file modified
+1 -1
ldap/servers/plugins/syntaxes/tel.c
file modified
+1 -1
ldap/servers/plugins/syntaxes/validate_task.c
file modified
+2 -2
ldap/servers/plugins/usn/usn.c
file modified
+1 -1
ldap/servers/plugins/usn/usn.h
file modified
+2 -2
ldap/servers/plugins/usn/usn_cleanup.c
file modified
+1 -1
ldap/servers/plugins/views/views.c
file modified
+10 -10
ldap/servers/slapd/agtmmap.h
file modified
+0 -2
ldap/servers/slapd/attrsyntax.c
file modified
+3 -3
ldap/servers/slapd/auth.c
file modified
+4 -4
ldap/servers/slapd/back-ldbm/dblayer.c
file modified
+10 -10
ldap/servers/slapd/back-ldbm/idl.c
file modified
+1 -1
ldap/servers/slapd/back-ldbm/idl_new.c
file modified
+1 -1
ldap/servers/slapd/back-ldbm/idl_shim.c
file modified
+3 -3
ldap/servers/slapd/back-ldbm/proto-back-ldbm.h
file modified
+12 -12
ldap/servers/slapd/back-ldbm/sort.c
file modified
+1 -1
ldap/servers/slapd/back-ldbm/vlv_key.h
file modified
+1 -1
ldap/servers/slapd/back-ldbm/vlv_srch.h
file modified
+2 -2
ldap/servers/slapd/ch_malloc.c
file modified
+1 -1
ldap/servers/slapd/connection.c
file modified
+1 -1
ldap/servers/slapd/csngen.c
file modified
+5 -5
ldap/servers/slapd/daemon.c
file modified
+11 -11
ldap/servers/slapd/detach.c
file modified
+1 -1
ldap/servers/slapd/dn.c
file modified
+6 -6
ldap/servers/slapd/dse.c
file modified
+2 -2
ldap/servers/slapd/entry.c
file modified
+2 -1
ldap/servers/slapd/eventq.c
file modified
+1 -1
ldap/servers/slapd/factory.c
file modified
+1 -1
ldap/servers/slapd/fe.h
file modified
+12 -12
ldap/servers/slapd/fedse.c
file modified
+4 -4
ldap/servers/slapd/filter.c
file modified
+2 -1
ldap/servers/slapd/filterentry.c
file modified
+18 -5
ldap/servers/slapd/generation.c
file modified
+1 -1
ldap/servers/slapd/getfilelist.c
file modified
+2 -1
ldap/servers/slapd/index_subsys.h
file modified
+1 -1
ldap/servers/slapd/index_subsystem.c
file modified
+3 -3
ldap/servers/slapd/ldaputil.c
file modified
+2 -2
ldap/servers/slapd/libglobs.c
file modified
+79 -79
ldap/servers/slapd/localhost.c
file modified
+2 -2
ldap/servers/slapd/log.c
file modified
+6 -6
ldap/servers/slapd/main.c
file modified
+21 -21
ldap/servers/slapd/mapping_tree.c
file modified
+7 -7
ldap/servers/slapd/plugin.c
file modified
+7 -7
ldap/servers/slapd/plugin_mr.c
file modified
+2 -2
ldap/servers/slapd/protect_db.c
file modified
+4 -4
ldap/servers/slapd/protect_db.h
file modified
+1 -1
ldap/servers/slapd/proto-slap.h
file modified
+230 -230
ldap/servers/slapd/psearch.c
file modified
+2 -2
ldap/servers/slapd/resourcelimit.c
file modified
+2 -2
ldap/servers/slapd/sasl_map.c
file modified
+2 -2
ldap/servers/slapd/saslbind.c
file modified
+2 -2
ldap/servers/slapd/schema.c
file modified
+2 -2
ldap/servers/slapd/slap.h
file modified
+12 -2
ldap/servers/slapd/slapi-plugin.h
file modified
+1 -1
ldap/servers/slapd/slapi-private.h
file modified
+34 -25
ldap/servers/slapd/snmp_collator.c
file modified
+15 -15
ldap/servers/slapd/snmp_collator.h
file modified
+2 -2
ldap/servers/slapd/ssl.c
file modified
+6 -6
ldap/servers/slapd/str2filter.c
file modified
+4 -2
ldap/servers/slapd/tools/ldclt/ldcltU.c
file modified
+1 -1
ldap/servers/slapd/tools/pwenc.c
file modified
+2 -5
ldap/servers/slapd/tools/rsearch/infadd.c
file modified
+1 -1
ldap/servers/slapd/tools/rsearch/nametable.h
file modified
+1 -1
ldap/servers/slapd/tools/rsearch/rsearch.c
file modified
+3 -3
ldap/servers/slapd/util.c
file modified
+2 -2
ldap/servers/slapd/uuid.c
file modified
+9 -9
ldap/servers/slapd/uuid.h
file modified
+1 -1
ldap/servers/slapd/vattr.c
file modified
+6 -6
ldap/servers/snmp/ldap-agent.h
file modified
+1 -1
ldap/servers/snmp/main.c
file modified
+1 -1
lib/libsi18n/makstrdb.c
file modified
+1 -1
    Ticket 48979 - Allow to compile 389ds with warning Wstrict-prototypes
    
    - Remove unused forward declaration
    - Remove declaration of errno
    
    The declaration of errno is in the header file errno.h
    which is alreadu included in ldap/servers/slapd/agtmmap.h
    
    - Remove explicit casting of db_env_set_func_exists
    - Fix casting of db_env_set_func_seek calback
    - Fix prototype of str2simple
    - Fix prototypes in str2filter.c
    
    ldap/servers/slapd/str2filter.c:22:15: warning: function declaration isn't a prototype [-Wstrict-prototypes]
     static struct slapi_filter *str2list();
                   ^~~~~~~~~~~~
    ldap/servers/slapd/str2filter.c:23:1: warning: function declaration isn't a prototype [-Wstrict-prototypes]
     static int  str2subvals();
    
    - Fix prototype vlv_getindexnames
    - Fix prototypes in plugins/replication/repl5_prot_private.h
    
    Use exact prototypes for functions Windows_Tot_Protocol_new and
    Windows_Inc_Protocol_new
    
    - Fix prototype setup_internal_backends
    - Fix prototypes in repl5_prot_private.h
    - Fix declaration of get_substring_filter
    - Fix declarations in ldap/servers/slapd/filterentry.c
    - Prepare for fixing avl_free prototype
    
    The prototyep of the function avl_free is:
       "int avl_free(Avlnode *root, IFP dfree);"
    and IFP is a typedef for function returning int
    with undefined parameters.
    
    This patch definition of callbacks used in function avl_free
    to avoid warnings Wincompatible-pointer-types
    
    e.g.
    ldap/servers/plugins/roles/roles_cache.c: In function 'roles_cache_role_object_free':
    ldap/servers/plugins/roles/roles_cache.c:2145:35: warning: passing argument 2 of 'avl_free' from incompatible pointer type [-Wincompatible-pointer-types]
         avl_free(this_role->avl_tree, roles_cache_role_object_nested_free);
                                       ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    In file included from ./ldap/servers/slapd/slap.h:113:0,
                     from ldap/servers/plugins/roles/roles_cache.c:24:
    ./ldap/include/avl.h:75:13: note: expected 'IFP {aka int (*)()}' but argument is of type 'void (*)(role_object_nested *) {aka void (*)(struct _role_object_nested *)}'
     extern int  avl_free( Avlnode *root, IFP dfree );
                 ^~~~~~~~
    
    - Use strict prototypes in avl.h
    
    There is a change in definiton of avl_ functions.
    The type of data was changed caddr_t into "void *".
    This change was necessary because avl_* functions
    were used also with other tyes then caddr_t and there
    would be compile time warning Wincompatible-pointer-types
    
    There is still one declaration/typedef which is not
    prototype. And it is a typedef for callbacks (IFP)
    which is used by avl_* functions and cannot have defined
    argumets.
    
    - Suppress warnings caused by undefined parameters in IFP
    - Suppress Wstrict-prototypes
    - Fix warnings Wstrict-prototypes
    
    Functions which does not expect any agumets shoudl be declared with void
    as parameter otherwise they can expect any count of arguments.
    
    https://fedorahosted.org/389/ticket/48979
    
    Author: lslebodn
    
    Review by: wibrown (Thanks so much Lukas!)
    
        
file modified
+1 -1
file modified
+1 -1
file modified
+1 -1
file modified
+1 -1
file modified
+1 -1
file modified
+22 -13
file modified
+13 -13
file modified
+20 -20
file modified
+19 -19
file modified
+0 -2
file modified
+4 -4
file modified
+5 -5
file modified
+11 -11
file modified
+1 -1
file modified
+6 -6
file modified
+2 -2
file modified
+2 -1
file modified
+1 -1
file modified
+1 -1
file modified
+12 -12
file modified
+4 -4
file modified
+2 -1
file modified
+79 -79
file modified
+6 -6
file modified
+21 -21
file modified
+7 -7
file modified
+230 -230
file modified
+2 -2
file modified
+2 -2
file modified
+12 -2
file modified
+6 -6
file modified
+2 -2
file modified
+9 -9
file modified
+1 -1
file modified
+6 -6
file modified
+1 -1
file modified
+1 -1