From 32be56b5139a3e84d58c19cf3ee2ee38030fc67f Mon Sep 17 00:00:00 2001
From: William Brown <william@blackhats.net.au>
Date: Jan 07 2020 02:44:30 +0000
Subject: Ticket 50727 - change syntax validate by default in 1.4.2


Bug Description: The default syntax validate for 1.4.2 should be changed to
a softer introduction so that admins have time to prepare for the change
of query behaviour in 1.4.3.

Fix Description: Change default in 1.4.2 to warn-invalid, 1.4.3 will
remain as process-safe.

https://pagure.io/389-ds-base/issue/50727

Author: William Brown <william@blackhats.net.au>

Review by: tbordaz (Thanks)

---

diff --git a/ldap/servers/slapd/libglobs.c b/ldap/servers/slapd/libglobs.c
index 549617d..90c1e3d 100644
--- a/ldap/servers/slapd/libglobs.c
+++ b/ldap/servers/slapd/libglobs.c
@@ -1783,7 +1783,7 @@ FrontendConfig_init(void)
      * scheme set in cn=config
      */
     init_enable_upgrade_hash = cfg->enable_upgrade_hash = LDAP_ON;
-    init_verify_filter_schema = cfg->verify_filter_schema = SLAPI_WARN_SAFE;
+    init_verify_filter_schema = cfg->verify_filter_schema = SLAPI_WARN_UNSAFE;
 
     /* Done, unlock!  */
     CFG_UNLOCK_WRITE(cfg);
@@ -7692,7 +7692,7 @@ config_set_specialfilterverify(slapdFrontendConfig_t *slapdFrontendConfig, slapi
         return LDAP_OPERATIONS_ERROR;
     }
 
-    slapi_special_filter_verify_t p_val = SLAPI_WARN_SAFE;
+    slapi_special_filter_verify_t p_val = SLAPI_WARN_UNSAFE;
 
     /* on/warn/off retained for legacy reasons due to wbrown making terrible mistakes :( :( */
     if (strcasecmp(value, "on") == 0) {
@@ -8052,7 +8052,7 @@ config_set_value(
             slapi_entry_attr_set_charptr(e, cgas->attr_name, "off");
         } else {
             /* Default to safe warn-proccess-safely */
-            slapi_entry_attr_set_charptr(e, cgas->attr_name, "process-safe");
+            slapi_entry_attr_set_charptr(e, cgas->attr_name, "warn-invalid");
         }
 
         break;