Ticket #161 - Review and address latest Coverity issues
    
    https://fedorahosted.org/389/ticket/161
    Resolves: Ticket #161
    Bug Description: Review and address latest Coverity issues
    Reviewed by: nhosoi (Thanks!)
    Branch: master
    Fix Description:
    12486 12485 12484 Resource leak In
    linked_attrs_add_backlinks_callback(): Leak of memory or pointers to
    system resources
    the return -1 left targetsdn, targets, and pb dangling
    allocate targetsdn after shutdown check - instead of return -1, goto done and free resources at done:
    
    12481 Resource leak In config_set_default_naming_context(): Leak of
    memory or pointers to system resources
    free suffix before return
    
    12477 Uninitialized pointer read In index_addordel_entry(): Reads an
    uninitialized pointer or its target
    use LDBM_PARENTID_STR instead of type
    
    12476 Dereference after null check In string_assertion2keys_ava():
    Pointer is checked against null but then dereferenced anyway
    check for NULL val
    
    12475 Logically dead code In _entryrdn_insert_key(): Code can never be
    reached because of a logical contradiction
    get rid of dead code
    
    12448 Time of check time of use In INTdir_create_all(): A check occurs
    on a file's attributes before the file is used in a privileged
    operation, but things may have changed
    get rid of unused code
    
    12447-12444 Time of check time of use
    use open() to open the file, then use the functions that take an fd to
    further test or access the file - this prevents someone changing the file
    between functions that only use the filename
    
    12434-12425 Copy into fixed size buffer
    use strncpy or snprintf and make sure the string is null terminated
    
    Platforms tested: RHEL6 x86_64, Fedora 16
    Flag Day: no
    Doc impact: no