#11058 whois update were broken by oscar user
Closed: Fixed a year ago by kevin. Opened a year ago by pemensik.

NOTE

If your issue is for security or deals with sensitive info please
mark it as private using the checkbox below.

Describe what you would like us to do:


When do you need this to be done by? (YYYY/MM/DD)


ASAP


The oscar user is a take on a US childrens show character (He lives in a garbage can...) it's been that way since koji was setup in the Fedora 7 days.

https://fedoraproject.org/wiki/Koji/GarbageCollection

You waited too long after doing the builds before submitting them and they were untagged. In 30more days they would have been deleted.
You can easily avoid the rest of the process with:

koji tag-build f36-updates-candidate whois-5.5.14-1.fc36
koji tag-build f37-updates-candidate whois-5.5.14-1.fc37

(which I have now done).

They should go out in the next push.

We do need to fix the user who somehow got that username. ;(

Shouldn't it write at least some comment to its update, if there is some? The message is not really clear. I think the bot should not cleanup any builds which are already part of update, unless whole update is being closed.

So, it looks like this was just really bad timing. ;(

The build happened.
A bunch of time passed.
You filed the update.
Right after that, but before the update was pushed to testing, garbage collection hit it's timeout and untagged it.
Update unhappy.

If it had hit before you filed the update, bodhi wouldn't have let you file the update without retagging it.
If it had hit after you filed the update, garbage collection would have ignored it because it was in a tag it knows not to untag from.

:(

So, I am not sure how we can improve this case.

Metadata Update from @phsmoura:
- Issue priority set to: Waiting on Assignee (was: Needs Review)
- Issue tagged with: high-trouble, low-gain, releng

a year ago

I think improvement is simple. It should try to untag the build only in case it is not included in an active update. Unless the update is change to include more recent build or invalidate it, it should consider that build active and not apply garbage collection on it. I think garbage collection should be started again when the build is not used is any update.

Right after that, but before the update was pushed to testing, garbage collection hit it's timeout and untagged it.

As soon as an update is created, and before it is actually pushed to testing, the builds are marked -signing-pending and then -updates-testing-pending. Maybe the gc policy can be tweaked to skip builds which have those tags? I do not think bodhi will let stale builds with those tags laying around.

Yes, we can, and I have now in ansible 584d9e6406b6379adabd429814f21a47b671d5bb
I told koji-gc to keep anything in *pending tags and not untag them. That should avoid this window.

Metadata Update from @kevin:
- Issue close_status updated to: Fixed
- Issue status updated to: Closed (was: Open)

a year ago

Log in to comment on this ticket.

Metadata